Patch Missing from 3.6 Tarball

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Patch Missing from 3.6 Tarball

Ian Clark-2-2
It seems that a bugfix made it into the 3.5-3.6 patchfile, but failed
to make it into the 3.6 tarball. I recently downloaded the 3.6 tarball
to play around with nakedmud, but recevied SEGV's whenever a command
was added from python (via add_cmd) that did not have a docstring
attached. It can be reproduced by `cp doc/mud_test.py lib/pymodules/`
from a fresh 3.6 tarball.

I then downloaded the 3.5 tarball and applied the 3.5-3.6 patchfile
and diff'd that against the 3.6 tarball and it seems the fix for the
previous problem was included in the patchfile, but not the tarball. I
have included a patch comparing the v3.5 w/ 3.6 patch against 3.6
tarball.

I know if I didn't know C I probably would have completely written off
nakedmud if changes to a python file caused it to seg fault. So I
would suggest putting this fix into the 3.6 tarball for other curious
folk. :)

Thanks for all your work on nakedmud, it'll be interesting digging through it.

Ian

------------------------------------

Yahoo! Groups Links

<*> To visit your group on the web, go to:
    http://groups.yahoo.com/group/nakedmud/

<*> Your email settings:
    Individual Email | Traditional

<*> To change settings online go to:
    http://groups.yahoo.com/group/nakedmud/join
    (Yahoo! ID required)

<*> To change settings via email:
    mailto:[hidden email]
    mailto:[hidden email]

<*> To unsubscribe from this group, send an email to:
    [hidden email]

<*> Your use of Yahoo! Groups is subject to:
    http://docs.yahoo.com/info/terms/


missing-3.6.patch (1018 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Patch Missing from 3.6 Tarball

Geoff Hollis
whoops! Thank you very much. I'll get that fix up today.

On Jun 12, 2008, at 3:51 PM, Ian Clark wrote:

> It seems that a bugfix made it into the 3.5-3.6 patchfile, but failed
> to make it into the 3.6 tarball. I recently downloaded the 3.6 tarball
> to play around with nakedmud, but recevied SEGV's whenever a command
> was added from python (via add_cmd) that did not have a docstring
> attached. It can be reproduced by `cp doc/mud_test.py lib/pymodules/`
> from a fresh 3.6 tarball.
>
> I then downloaded the 3.5 tarball and applied the 3.5-3.6 patchfile
> and diff'd that against the 3.6 tarball and it seems the fix for the
> previous problem was included in the patchfile, but not the tarball. I
> have included a patch comparing the v3.5 w/ 3.6 patch against 3.6
> tarball.
>
> I know if I didn't know C I probably would have completely written off
> nakedmud if changes to a python file caused it to seg fault. So I
> would suggest putting this fix into the 3.6 tarball for other curious
> folk. :)
>
> Thanks for all your work on nakedmud, it'll be interesting digging  
> through it.
>
> Ian
>  <missing-3.6.patch>